swagle commented on a change in pull request #546: HDDS-2847. Recon should
track containers that are missing along with …
URL: https://github.com/apache/hadoop-ozone/pull/546#discussion_r380850710
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconControllerModule.java
##########
@@ -96,6 +106,34 @@ protected void configure() {
.to(ReconStorageContainerManagerFacade.class).in(Singleton.class);
}
+ @Provides
+ @Singleton
Review comment:
AFAIK, DAOs are in-expensive to create so enforcinf Singleton's might be an
anti-pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
