adoroszlai commented on a change in pull request #546: HDDS-2847. Add Recon 
tasks for tracking missing containers (FSCK) and syncing deleted pipelines from 
SCM.
URL: https://github.com/apache/hadoop-ozone/pull/546#discussion_r381557489
 
 

 ##########
 File path: 
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconPipelineFactory.java
 ##########
 @@ -48,8 +48,8 @@
 
     @Override
     public Pipeline create(HddsProtos.ReplicationFactor factor){
-      LOG.warn("Trying to create pipeline in Recon, which is prohibited!");
-      return null;
+      throw new RuntimeException(
 
 Review comment:
   I think `UnsupportedOperationException` would be more appropriate.
   
   Also, what about the other `create` method below?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to