lokeshj1703 commented on a change in pull request #551: HDDS-2717. Handle chunk increments in datanode URL: https://github.com/apache/hadoop-ozone/pull/551#discussion_r387702775
########## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java ########## @@ -81,18 +82,17 @@ private final BlockData.Builder containerBlockData; private XceiverClientManager xceiverClientManager; private XceiverClientSpi xceiverClient; - private final ContainerProtos.ChecksumType checksumType; private final int bytesPerChecksum; private int chunkIndex; - private int chunkSize; + private final AtomicLong chunkOffset = new AtomicLong(); Review comment: I think we will need to decrease the chunkOffset in case of retries and failures? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
