lokeshj1703 commented on a change in pull request #551: HDDS-2717. Handle chunk
increments in datanode
URL: https://github.com/apache/hadoop-ozone/pull/551#discussion_r387710586
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
##########
@@ -360,20 +359,26 @@ private void watchForCommit(boolean bufferFull) throws
IOException {
}
private CompletableFuture<ContainerProtos.
- ContainerCommandResponseProto> executePutBlock()
- throws IOException {
+ ContainerCommandResponseProto> executePutBlock(boolean close,
+ boolean force) throws IOException {
Review comment:
I am forgetting the reason for the force flag here. In what cases is it
different from close flag and what does it mean logically w.r.t put block?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
