avijayanhwx commented on a change in pull request #629: HDDS-3071. Datanodes
unable to connect to recon in Secure Environment
URL: https://github.com/apache/hadoop-ozone/pull/629#discussion_r387908107
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/SCMConnectionManager.java
##########
@@ -160,22 +161,45 @@ private void addSCMServer(InetSocketAddress address,
long sleepTime,
"Ignoring the request.");
return;
}
- RPC.setProtocolEngine(conf, StorageContainerDatanodeProtocolPB.class,
- ProtobufRpcEngine.class);
- long version =
- RPC.getProtocolVersion(StorageContainerDatanodeProtocolPB.class);
-
- RetryPolicy retryPolicy =
- RetryPolicies.retryForeverWithFixedSleep(
- sleepTime, TimeUnit.MILLISECONDS);
- StorageContainerDatanodeProtocolPB rpcProxy = RPC.getProtocolProxy(
- StorageContainerDatanodeProtocolPB.class, version,
- address, UserGroupInformation.getCurrentUser(), conf,
- NetUtils.getDefaultSocketFactory(conf), getRpcTimeout(),
- retryPolicy).getProxy();
-
- StorageContainerDatanodeProtocolClientSideTranslatorPB rpcClient =
- new StorageContainerDatanodeProtocolClientSideTranslatorPB(rpcProxy);
+
+ StorageContainerDatanodeProtocolClientSideTranslatorPB rpcClient;
+ if (!passiveScm) {
Review comment:
Yes, I agree. Will refactor this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
