xiaoyuyao commented on a change in pull request #629: HDDS-3071. Datanodes
unable to connect to recon in Secure Environment
URL: https://github.com/apache/hadoop-ozone/pull/629#discussion_r387916168
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java
##########
@@ -407,14 +387,48 @@ private static String flatten(String input) {
.replaceAll(" +", " ");
}
- protected String getScmDatanodeAddressKey() {
+ protected RPC.Server getRpcServer(OzoneConfiguration conf,
+ InetSocketAddress datanodeRpcAddr,
Review comment:
NIT: If we add a parameter Class<?> protocol for protocol? we don't need to
overwrite getRpcServer in ReconDatanodeProtocolServer class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
