sodonnel commented on issue #690: HDDS-3221. Refactor SafeModeHandler to use a Notification Interface URL: https://github.com/apache/hadoop-ozone/pull/690#issuecomment-600895440 > Safemode state change event handler should only worry about starting the services that are required to be started while coming out of safemode. I see the safemode handlers job as dispatching a notification to which ever objects are interested on safemode state change and allow the receiving objects to decide what to do with that notification. We could flip it around and have the other objects poll safemode handler but that does not feel as generic to me. > I agree that the existing code doesn't reflect this, I have always wanted to make this change. Are you saying that the changes I have made move things in the direction you would like to see, and are therefore happy with this change?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
