elek commented on issue #690: HDDS-3221. Refactor SafeModeHandler to use a Notification Interface URL: https://github.com/apache/hadoop-ozone/pull/690#issuecomment-601129563 Thanks the answer. I understand that EventQueue seems to be more complex but as it's the heart of the SCM I would prefer to make it more transparent if this is the problem. I think an async event handler can decrease the coupling instead of using strong coupling which makes the testing more simple and reliable (even if it seems to be a little bit more complex...) > > That said, please let me know if you have a strong preference to move to the EventQueue model. I don't understand fully your answer. Do you propose to start to use EventQueue in a separated patch but before the other refactors, or do you propose to skip the usage of EventQueue until the far future (= don't use it). I think it would be useful to use just one unified notification interface inside SCM>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
