mukul1987 commented on a change in pull request #709: HDDS-3244. Improve write
efficiency by opening RocksDB only once
URL: https://github.com/apache/hadoop-ozone/pull/709#discussion_r396498271
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java
##########
@@ -73,14 +71,6 @@ public static void createContainerMetaData(File
containerMetaDataPath, File
throw new IOException("Unable to create directory for metadata storage."
+
" Path: " + containerMetaDataPath);
}
- MetadataStore store = MetadataStoreBuilder.newBuilder().setConf(conf)
- .setCreateIfMissing(true).setDbFile(dbFile).build();
Review comment:
Thanks for working on this @runzhiwang. Can we add to the cache here ?
Also the entry should be added to cache here and not in the apply
transaction phase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
