bshashikant commented on a change in pull request #709: HDDS-3244. Improve
write efficiency by opening RocksDB only once
URL: https://github.com/apache/hadoop-ozone/pull/709#discussion_r397162598
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java
##########
@@ -73,14 +71,6 @@ public static void createContainerMetaData(File
containerMetaDataPath, File
throw new IOException("Unable to create directory for metadata storage."
+
" Path: " + containerMetaDataPath);
}
- MetadataStore store = MetadataStoreBuilder.newBuilder().setConf(conf)
- .setCreateIfMissing(true).setDbFile(dbFile).build();
Review comment:
@runzhiwang , createContainer happens as a part of writeStateMachineData
which gets executed on all nodes(leader and follower) independent of each
other. I would prefer to add it to the container cache as soon as it gets
created on the datanode on disk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
