bshashikant commented on a change in pull request #709: HDDS-3244. Improve 
write efficiency by opening RocksDB only once
URL: https://github.com/apache/hadoop-ozone/pull/709#discussion_r398305798
 
 

 ##########
 File path: 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java
 ##########
 @@ -73,14 +71,6 @@ public static void createContainerMetaData(File 
containerMetaDataPath, File
       throw new IOException("Unable to create directory for metadata storage." 
+
           " Path: " + containerMetaDataPath);
     }
-    MetadataStore store = MetadataStoreBuilder.newBuilder().setConf(conf)
-        .setCreateIfMissing(true).setDbFile(dbFile).build();
 
 Review comment:
   Thanks @runzhiwang . readStateMachine getting invoked after 
writeStateMachineData completes, is happening bcoz of recent change. i agree 
with ur proposal here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to