runzhiwang commented on a change in pull request #709: HDDS-3244. Improve write
efficiency by opening RocksDB only once
URL: https://github.com/apache/hadoop-ozone/pull/709#discussion_r398310403
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java
##########
@@ -73,14 +71,6 @@ public static void createContainerMetaData(File
containerMetaDataPath, File
throw new IOException("Unable to create directory for metadata storage."
+
" Path: " + containerMetaDataPath);
}
- MetadataStore store = MetadataStoreBuilder.newBuilder().setConf(conf)
- .setCreateIfMissing(true).setDbFile(dbFile).build();
Review comment:
@bshashikant Thanks, I will open another PR to fix the dependent of leader
and follower.
And do you think where we should put the RocksDB into cache ? Here or
CommitData i.e. apply transaction phase. If place it here, once cache miss,
follower must wait leader, the wait time including RocksDB.open which cost
200ms. If place it in CommitData, once cache miss, follower need not wait so
long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
