adoroszlai commented on a change in pull request #734: HDDS-3240. Improve write
efficiency by creating container in parallel
URL: https://github.com/apache/hadoop-ozone/pull/734#discussion_r399776002
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -664,12 +689,12 @@ private ByteString getCachedStateMachineData(Long
logIndex, long term,
future.complete(
getCachedStateMachineData(entry.getIndex(), entry.getTerm(),
requestProto));
- } catch (IOException e) {
+ } catch (Exception e) {
metrics.incNumReadStateMachineFails();
future.completeExceptionally(e);
}
return future;
- }, getChunkExecutor(requestProto.getWriteChunk()));
+ }, getReadChunkExecutor(requestProto.getWriteChunk()));
Review comment:
Instead of introducing another set of executors for read chunk operation,
can the cache lookup be executed in the per-container executor returned by
`getCommandExecutor`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
