xiaoyuyao commented on a change in pull request #806: HDDS-3374. 
OMVolumeSetOwnerRequest doesn't check if user is already the owner
URL: https://github.com/apache/hadoop-ozone/pull/806#discussion_r408229442
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/volume/OMVolumeSetOwnerResponse.java
 ##########
 @@ -55,11 +56,27 @@ public OMVolumeSetOwnerResponse(@Nonnull OMResponse 
omResponse,
 
   /**
    * For when the request is not successful or it is a replay transaction.
 
 Review comment:
   should we remove this comment as checkStatusNotOK is now conditioned with 
success=true? Also, do we redirect existing callers for success=false case 
appropriately?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to