bharatviswa504 commented on a change in pull request #806: HDDS-3374.
OMVolumeSetOwnerRequest doesn't check if user is already the owner
URL: https://github.com/apache/hadoop-ozone/pull/806#discussion_r408262348
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/volume/OMVolumeSetOwnerResponse.java
##########
@@ -55,11 +56,27 @@ public OMVolumeSetOwnerResponse(@Nonnull OMResponse
omResponse,
/**
* For when the request is not successful or it is a replay transaction.
Review comment:
Just to add more info, we set the success flag and also there is a response
which we return that is used by the end client which has a response flag which
is set based on the result of the operation.
```
OMClientResponse onSuccess(OMResponse.Builder omResponse,
OmBucketInfo omBucketInfo, boolean operationResult) {
omResponse.setSuccess(operationResult);
omResponse.setAddAclResponse(AddAclResponse.newBuilder()
.setResponse(operationResult));
```
But in OmVolumeSetOwner case, there is no such flag. If we can introduce a
flag in SetVolumePropertyResponse, we can use the success flag.
omResponse.setSetVolumePropertyResponse(
SetVolumePropertyResponse.newBuilder().build());
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
