elek commented on issue #745: HDDS-3315. Use EventQueue for delayed/immediate safe mode notifications URL: https://github.com/apache/hadoop-ozone/pull/745#issuecomment-615224653 Thanks the review @sodonnel > I wonder if we should move the logic in SafeModeHandler.onMessage() into SCMSafeModeManager.emitSafeModeStatus() - that would allow us to get rid of that class entirely and make the logic slightly easier to follow. Good idea, and it seems to be a small change. I added it to this patch (+ I improved to unit test a little bit during the move).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
