bharatviswa504 commented on a change in pull request #854:
URL: https://github.com/apache/hadoop-ozone/pull/854#discussion_r412395406
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java
##########
@@ -81,20 +82,26 @@ public Response getClusterState() {
stats.getScmUsed().get(), stats.getRemaining().get());
ClusterStateResponse.Builder builder = ClusterStateResponse.newBuilder();
try {
- builder.setVolumes(
- omMetadataManager.getVolumeTable().getEstimatedKeyCount());
+ Table volumeTable = omMetadataManager.getVolumeTable();
Review comment:
Instead of not null checks, can we have a state in MetadataManager like
INITIALIZED, STOPPED? This will help be future proof, and if anywhere this
check is required it will be generic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
