bharatviswa504 commented on a change in pull request #854:
URL: https://github.com/apache/hadoop-ozone/pull/854#discussion_r412537904
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/recovery/ReconOmMetadataManagerImpl.java
##########
@@ -120,4 +122,11 @@ public long getLastSequenceNumberFromDB() {
}
}
+ /**
+ * Check if OM tables are initialized.
+ * @return if OM Tables are initialized
+ */
+ public boolean isOmTablesInitialized() {
Review comment:
Missed `@override` notion, and same comment as above related to Javadoc
or it can be completely removed.
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/recovery/ReconOMMetadataManager.java
##########
@@ -41,4 +41,10 @@
* Database.
*/
long getLastSequenceNumberFromDB();
+
+ /**
+ * Check if OM tables are initialized.
+ * @return if OM Tables are initialized
Review comment:
Minor NIT: return true if OM Tables are initialized, otherwise false.
##########
File path:
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json
##########
@@ -378,11 +378,11 @@
}
],
"missingSince": 1578491371528,
- "pipelineId": "05e3d908-ff01-4ce6-ad75-f3ec79bcc7982"
+ "pipelineID": "05e3d908-ff01-4ce6-ad75-f3ec79bcc7982"
},
{
- "id": 2,
- "keys": 5943,
+ "containerID": 2,
Review comment:
Not understood why these are changed, and how it is related to this
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
