bharatviswa504 commented on issue #742: URL: https://github.com/apache/hadoop-ozone/pull/742#issuecomment-618108926
> Thank you Bharat for working on this. I have one suggestion. > ChunkLayoutVersion is always gonna have FILE_PER_BLOCK and FILE_PER_CHUNK. Anytime we need to make a change i.e. add a new LayoutVersion, we will end up having to add 2 LayoutVersions to take into account these 2 types of chunk storage. Instead, we can we have a separate LayoutVersion for non-chunk related versioning. Current changes could probably go under BlockLayoutVersion. What do you think? Thanks for the review. I like the idea, when implementing also i thought to do this i need to add one more layout version field to the container file. And Old Containers will not have this field at all. Instead of doing all these, I have taken a simple approach of reusing chunkLayoutVersion. And also I have opened a Jira to rename chunkLayoutVersion -> ContainerLayOutVersion. Adding 2 more versions is not a big change and it is simple, with one layout version code looks simple I believe. If you are strongly in favor of that, I can open a new Jira and for doing this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
