bharatviswa504 commented on issue #742:
URL: https://github.com/apache/hadoop-ozone/pull/742#issuecomment-618123719


   > In that case, why don't we go with FILE_PER_BLOCK approach and discard the 
FILE_PER_CHUNK going forward?
   
   Yes, we can remove it if not needed. But I don't want to touch this in this 
Jira. I can open a new Jira and if we get consensus we can remove it.
   
   
   `Specifically with this change, this is not really a user configurable 
parameter. This version onwards metadata will always be stored in DB 
irrespective of what value "ozone.scm.chunk.layout" is configured to.`
   
   The reason for not removing the older version is for this, which I have 
mentioned in the code comments. Technically in newer software version I can 
remove FILE_PER_CHUNK and FILE_PER_BLOCK.
   
   ```
         // If on newer version of software if user configured mistakenly to use
         // older version, log an warning message. Not changing to newer layouts
         // for now to give an option to user if some bug present in newer 
layout
         // version, user has option to use still older version. We can change
         // this automatically in newer releases if no issues with newer 
version.
   ```
   
   This is done for being on safer side. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to