smengcl edited a comment on pull request #865: URL: https://github.com/apache/hadoop-ozone/pull/865#issuecomment-618615296
Comments: 1. I tried to reuse the existing contract test files but it Hadoop Common didn't pass parameters to `getTestFileSystem()` or `getTestPath()`. Hence the copy and paste classes. Questions: 1. RootDir test doesn't seem to pass for the current state of OFS. e.g. rm /* doesn't really work in OFS at the moment: <img width="1415" alt="ContractRootDir" src="https://user-images.githubusercontent.com/50227127/80141341-41779f00-855e-11ea-9665-66f3dbd311aa.png";> ~~Maybe I can set the "root" to a bucket to pass the test?~~ To be fully compliant with RootDir contract test, OFS needs to support deleting volumes with `rm` command. I think we should learn from RBF which [disables some RootDir tests](https://github.com/apache/hadoop/blob/ffbb6b6557f4eb8587c7d57cda38f2a0de573f8b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/fs/contract/router/TestRouterHDFSContractRootDirectory.java#L50-L73). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/50227127/80141341-41779f00-855e-11ea-9665-66f3dbd311aa.png"](https://user-images.githubusercontent.com/50227127/80141341-41779f00-855e-11ea-9665-66f3dbd311aa.png"){kind=link}