smengcl commented on a change in pull request #865: URL: https://github.com/apache/hadoop-ozone/pull/865#discussion_r420140845
########## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/contract/rooted/ITestRootedOzoneContractRootDir.java ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.ozone.contract.rooted; + +import java.io.IOException; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest; +import org.apache.hadoop.fs.contract.AbstractFSContract; + +import org.junit.AfterClass; +import org.junit.BeforeClass; + +/** + * Ozone contract test for ROOT directory operations. + */ +public class ITestRootedOzoneContractRootDir extends + AbstractContractRootDirectoryTest { + + @BeforeClass + public static void createCluster() throws IOException { + RootedOzoneContract.createCluster(); + } + + @AfterClass + public static void teardownCluster() throws IOException { + RootedOzoneContract.destroyCluster(); + } + + @Override + protected AbstractFSContract createContract(Configuration conf) { + return new RootedOzoneContract(conf); + } + + @Override + public void testRmEmptyRootDirNonRecursive() { + // OFS doesn't support deleting volumes via rm + } + + @Override + public void testRmRootRecursive() { + // OFS doesn't support deleting volumes via rm + } + + @Override + public void testListEmptyRootDirectory() { Review comment: It fails because the test tries to delete dirs(volumes) at root: ```java @Test public void testListEmptyRootDirectory() throws IOException { skipIfUnsupported(TEST_ROOT_TESTS_ENABLED); FileSystem fs = getFileSystem(); Path root = new Path("/"); FileStatus[] statuses = fs.listStatus(root); for (FileStatus status : statuses) { ContractTestUtils.assertDeleted(fs, status.getPath(), true); } ``` then: ```java public static void assertDeleted(FileSystem fs, Path file, boolean recursive, boolean allowRootOperations) throws IOException { rejectRootOperation(file, allowRootOperations); assertPathExists(fs, "about to be deleted file", file); boolean deleted = fs.delete(file, recursive); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
