bharatviswa504 edited a comment on pull request #855: URL: https://github.com/apache/hadoop-ozone/pull/855#issuecomment-621947648
> > Thanks the answer @bharatviswa504 . Still working on my understanding but one small comments in the mean time: > > If the table is TransactionInfo -> currentTerm-transactionIndex as you write in the Jira: can we modify `Table<String, String>` to have real types + Codec. Can help the understanding IMHO. > > Key - TRANSACTIONINFO (string) > Value - currentTerm#transactionIndex (Also a string) not sure what is meant by real types here? > > As both are strings, so used a String codec which already exists. The reason for not creating a proto object is for every iteration I need to create a proto object and then it will be converted to bytes when flushed to DB (Anyway this info is not passed via wire, it is used in persisting to DB only). I think this is proto creation is unnecessary and the same can be done with simple string i think this should be fine. If needed for understandability I can update java doc and by reading the OMTransactionInfo class will help. Let me know your thoughts. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
