bharatviswa504 commented on pull request #855: URL: https://github.com/apache/hadoop-ozone/pull/855#issuecomment-624926581
Thank You @elek for the review. I have addressed the review comments. `Do we need a generic settings/ table instead of introducing a new table every time when we need to store something on disk? In that case it would be more reasonable to use <String,String>.` I have created ratis log table, because in OM each information/entity is stored in a column family. And also we need to persist this information in DB because we want the operation to be atomic, so that when restart, we find lastAppliedIndex from DB, and start applying the transactions after this transaction so that we know this is the last transaction applied to DB and we don't need any special handling of replay in actual requests. (Right now in actual request logic, we have a code for replay, and it is difficult to maintain and the new requests implemented by developers need to know about this detail, with this the user can implement the actual logic for the request and donot need to worry about replay part) https://github.com/facebook/rocksdb/issues/2426 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
