xiaoyuyao commented on a change in pull request #941:
URL: https://github.com/apache/hadoop-ozone/pull/941#discussion_r428212741
##########
File path:
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java
##########
@@ -658,6 +658,19 @@ public String getUsername() {
return userName;
}
+ /**
+ * Get the root directory of Trash for a path in OFS.
+ * Returns /<volumename>/<bucketname>/.Trash/<username>
+ * Caller appends either Current or checkpoint timestamp for trash
destination
+ * @param path the trash root of the path to be determined.
+ * @return trash root
+ */
+ @Override
Review comment:
You also need to Override getTrashRoots() which returns all trash
locations under the root across multiple buckets. This should be very similar
to how Trash under encryption zone is handled in
DistributedFileSystem#getTrashRoots().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
