umamaheswararao commented on a change in pull request #941:
URL: https://github.com/apache/hadoop-ozone/pull/941#discussion_r428253556
##########
File path:
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OFSPath.java
##########
@@ -238,4 +248,23 @@ static String getTempMountBucketNameOfCurrentUser() throws
IOException {
String username = UserGroupInformation.getCurrentUser().getUserName();
return getTempMountBucketName(username);
}
+
+ /**
+ * Return trash root for the given path.
+ * @return trash root for the given path
+ */
+ public Path getTrashRoot() {
+ try {
+ String username = UserGroupInformation.getCurrentUser().getUserName();
+ URI uri = new URIBuilder().setScheme(OZONE_OFS_URI_SCHEME)
Review comment:
Thanks @xiaoyuyao for explanation. I agree on flipping folders here.
My point is: after looking at Trash impl demo today, in o3fs we seems to be
getting <user>/.Trash
My point is, this o3fs and ofs trash directories should be in sync. so that
emptier will not omit the trash dirs created by o3fs?
Also inside OM Server, we get trashRoots from the fs configured as OM. That
should default fs. When we configure ofs, it should also consider trash dirs
created by o3fs? I think yes, so that they both should be in sync.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
