bharatviswa504 commented on a change in pull request #941:
URL: https://github.com/apache/hadoop-ozone/pull/941#discussion_r428298169
##########
File path:
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OFSPath.java
##########
@@ -238,4 +248,23 @@ static String getTempMountBucketNameOfCurrentUser() throws
IOException {
String username = UserGroupInformation.getCurrentUser().getUserName();
return getTempMountBucketName(username);
}
+
+ /**
+ * Return trash root for the given path.
+ * @return trash root for the given path
+ */
+ public Path getTrashRoot() {
+ try {
+ String username = UserGroupInformation.getCurrentUser().getUserName();
+ URI uri = new URIBuilder().setScheme(OZONE_OFS_URI_SCHEME)
Review comment:
I am in favor of maintaining trash roots for ofs and o3fs the same (We
should override getTrashRoot for o3fs similar to this Jira), as
@umamaheswararao said in the first phase, we can reuse the code of hdfs logic
and run the same in OM with OFS filesystem object and also for this we need to
implement fs.getTrashRoots return path for all buckets in the system(Which can
be done in a separate Jira).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
