maobaolong commented on pull request #991:
URL: https://github.com/apache/hadoop-ozone/pull/991#issuecomment-636979218
@sodonnel Thank you for your review.
> With your change, does this command append to existing HADOOP_OPTS or
overwrite any existing arguments set by HADOOP_OPTS?
The function `hadoop_add_param <envvar> <checkstring> <appendstring>` will
append the `appendstring` if `checkstring` is not set.
$1 is what we are adding to
$2 is the name of what we want to add (key)
$3 is the key+value of what we're adding
As the jvmargs will bring a bundle of jvm arguments, so i just check the
whole arguments string as lazy.
> After a bit of trial and error I figure out that:
> Anything in HADOOP_OPTS comes first.
> These new JVM Flags are appended to that.
> Anything in HADOOP_CLIENT_OPTS is appended to that, eg:
>
> "$HADOOP_OPTS --jvmflags $HADOOP_CLIENT_OPTS"
Thank you for trial this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
