sodonnel commented on a change in pull request #991:
URL: https://github.com/apache/hadoop-ozone/pull/991#discussion_r435128845



##########
File path: hadoop-ozone/dist/src/shell/ozone/ozone
##########
@@ -31,6 +31,8 @@ function hadoop_usage
   hadoop_add_option "--hosts filename" "list of hosts to use in worker mode"
   hadoop_add_option "--loglevel level" "set the log4j level for this command"
   hadoop_add_option "--workers" "turn on worker mode"
+  hadoop_add_option "--jvmargs" "jvm arguments, append JVM options to any 
existing options defined in the HADOOP_OPTS environment variable. Any defined 
in HADOOP_CLIENT_OPTS will be append after these jvmargs"

Review comment:
       To keep this consistent with the other options, I think this new option 
should be:
   
   ```
   hadoop_add_option "--jvmargs jvm arguments", "append JVM options to any 
existing options defined in the HADOOP_OPTS environment variable. Any defined 
in HADOOP_CLIENT_OPTS will be append after these jvmargs"
   ```
   
   Please also remove the extra blank line after this new line of code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to