hanishakoneru commented on a change in pull request #1002:
URL: https://github.com/apache/hadoop-ozone/pull/1002#discussion_r437081323
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -3113,27 +3120,32 @@ private DBCheckpoint getDBCheckpointFromLeader(String
leaderId) {
return null;
}
+ void stopServices() throws Exception {
+ keyManager.stop();
+ stopSecretManager();
+ metadataManager.stop();
+
+ // s3SecretManager should also be stopped
Review comment:
If writes can happen then we should stop it, right?
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -3113,27 +3120,32 @@ private DBCheckpoint getDBCheckpointFromLeader(String
leaderId) {
return null;
}
+ void stopServices() throws Exception {
+ keyManager.stop();
+ stopSecretManager();
+ metadataManager.stop();
+
+ // s3SecretManager should also be stopped
Review comment:
If writes can happen then we should stop it, right?
But writes would have to come through Ratis server which will be paused. So
it should be okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
