bharatviswa504 commented on a change in pull request #1002:
URL: https://github.com/apache/hadoop-ozone/pull/1002#discussion_r436952743
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -3113,27 +3120,32 @@ private DBCheckpoint getDBCheckpointFromLeader(String
leaderId) {
return null;
}
+ void stopServices() throws Exception {
+ keyManager.stop();
+ stopSecretManager();
+ metadataManager.stop();
+
+ // s3SecretManager should also be stopped
Review comment:
Right now, we don't have any stop() for S3SecretManager and
PrefixManager.
And also for these, only read/write operations will happen. Write will go
through double buffer and read's will not happen anyway as this is not leader.
Do we still see issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
