avijayanhwx commented on pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083#issuecomment-645700635
Thank you for the explanation @maobaolong. > when i think we don't need this table, i need a way to remove the column family. Removing useless column family is a schema change, and schema changes across versions are generally handled by Upgrade handlers in systems. > In fact, without this PR, i can still create/delete the rocksdb by rocksdb/ldb, even i can remove > the rocksdb persistent file on the disk, because i'm the administrator of this Ozone cluster Yes, these types of destructive operations can be done possibly by naive users. But at least in that case, Ozone did not provide a direct way for the user to mess up its own DB. As @bharatviswa504 said, we need to put appropriate safeguards beforee this operation. Is it possible to move this to an "ozone admin" command, with an explicit confirmation by printing a warning message (with the table name), and the user to enter something like "delete" or "yes" to confirm? Also, in the case of OM HA, doesn't the user have to do it in every OM individually? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
