maobaolong commented on pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083#issuecomment-645708466
@bharatviswa504 Thank you for discuss with me. > Do you think having an admin check here would safeguard any user from doing this? I think it worth to do for many risky operation, but for this command, it cannot be executed remotely, it can be executed locally, so who can login the node of OM with the admin user that have prove that who have the admin permission. So, i mean, it does't need to do the safeguard check for this `drop_column_family` command. > even i can remove the rocksdb persistent file on the disk Sorry, i just an inappropriate example, another appropriate examples like following, they are all risky and necessary. - Admin move the rocksdb from one dir into another, - Admin backup&recover the rocksdb Another truth, without this PR, i can still create/delete the rocksdb by rocksdb/ldb, with this PR, i don't have to intall the rocksdb/ldb only. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
