xiaoyuyao commented on a change in pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#discussion_r443170256
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManager.java
##########
@@ -180,7 +180,7 @@ ContainerInfo getMatchingContainer(long size, String owner,
* @return ContainerInfo for the matching container.
*/
ContainerInfo getMatchingContainer(long size, String owner,
- Pipeline pipeline, List<ContainerID> excludedContainerIDS);
+ Pipeline pipeline, Set<ContainerID> excludedContainerIDS);
Review comment:
Can we change here to Collection<ContainerID> to make the interface
neutral to implementation? The underlying can be List or Set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
