xiaoyuyao commented on a change in pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#discussion_r443170321
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManager.java
##########
@@ -61,8 +61,8 @@ Pipeline createPipeline(ReplicationType type,
ReplicationFactor factor,
ReplicationFactor factor, Pipeline.PipelineState state);
List<Pipeline> getPipelines(ReplicationType type, ReplicationFactor factor,
- Pipeline.PipelineState state, Collection<DatanodeDetails> excludeDns,
- Collection<PipelineID> excludePipelines);
Review comment:
Can we keep the existing one parameter as Collection which allows
passing Set here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
