maobaolong commented on a change in pull request #1033:
URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r458794752
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
##########
@@ -164,9 +171,29 @@ public Void call() throws Exception {
HddsDatanodeService.class, args, LOG);
}
start(createOzoneConfiguration());
+ stopDataNodeShutdownHook = () ->
+ stopDataNode();
+ ShutdownHookManager.get().addShutdownHook(stopDataNodeShutdownHook,
+ SHUTDOWN_HOOK_PRIORITY);
join();
return null;
}
+
+ private void stopDataNode() {
+ Collection<EndpointStateMachine> endpointStateMachines =
+ datanodeStateMachine.getConnectionManager().getValues();
+ for (EndpointStateMachine endpointStateMachine : endpointStateMachines) {
+ try {
+ // Make sure the heartbeat is not sent
Review comment:
is not sent -> won't send
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
##########
@@ -708,6 +707,21 @@ private void updateNodeState(DatanodeInfo node,
Predicate<Long> condition,
}
}
+ /**
+ *
+ * @param datanodeDetails
+ */
+ public void stopNode(DatanodeDetails datanodeDetails)
+ throws NodeNotFoundException {
+ UUID uuid = datanodeDetails.getUuid();
+ NodeState state = nodeStateMap.getNodeState(uuid);
+ DatanodeInfo node = nodeStateMap.getNodeInfo(uuid);
+ nodeStateMap.updateNodeState(datanodeDetails.getUuid(), state,
+ NodeState.DEAD);
+ node.updateLastHeartbeatTime(0L);
Review comment:
Can you please explain why you set LastHeartbeatTime to 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
