maobaolong commented on a change in pull request #1033:
URL: https://github.com/apache/hadoop-ozone/pull/1033#discussion_r459897552
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
##########
@@ -708,6 +707,21 @@ private void updateNodeState(DatanodeInfo node,
Predicate<Long> condition,
}
}
+ /**
+ *
+ * @param datanodeDetails
+ */
+ public void stopNode(DatanodeDetails datanodeDetails)
+ throws NodeNotFoundException {
+ UUID uuid = datanodeDetails.getUuid();
+ NodeState state = nodeStateMap.getNodeState(uuid);
+ DatanodeInfo node = nodeStateMap.getNodeInfo(uuid);
+ nodeStateMap.updateNodeState(datanodeDetails.getUuid(), state,
+ NodeState.DEAD);
+ node.updateLastHeartbeatTime(0L);
Review comment:
Yeah, i got it, i agree that it can works, but the downside, we lost the
real lastHeartBeatTime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
