bharatviswa504 commented on a change in pull request #1286:
URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r466608698
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java
##########
@@ -457,38 +458,79 @@ public boolean deleteObject(String path) {
}
}
+ /**
+ * Helper function to check if the list of key paths are in the same volume
+ * and same bucket.
+ */
+ private boolean areInSameBucket(List<String> keyNameList) {
+ if (keyNameList.size() == 0) {
+ return true;
+ }
+ String firstKeyPath = keyNameList.get(0);
+ final String volAndBucket = new OFSPath(firstKeyPath).getNonKeyPath();
+ // If any key path's volume and bucket from the second element and on
+ // in the list doesn't match the first element's, hasDifferentVolAndBucket
+ // would be true
+ boolean hasDifferentVolAndBucket = keyNameList.stream().skip(1)
+ .anyMatch(p -> !(new OFSPath(p).getNonKeyPath().equals(volAndBucket)));
+ return !hasDifferentVolAndBucket;
+ }
+
/**
* Helper method to delete an object specified by key name in bucket.
*
- * @param pathList key name list to be deleted
+ * Only supports deleting keys in the same bucket in one call.
+ *
+ * Each item in the given list should be the String of an OFS path:
+ * e.g. ofs://om/vol1/buck1/k1
+ *
+ * @param keyNameList key name list to be deleted
* @return true if the key is deleted, false otherwise
*/
@Override
- public boolean deleteObjects(List<String> pathList) {
- // TODO: we will support deleteObjects in ofs.
- LOG.error("ofs currently does not support deleteObjects");
- return false;
+ public boolean deleteObjects(List<String> keyNameList) {
+ LOG.trace("issuing delete for keys: {}", keyNameList);
+ if (keyNameList.size() == 0) {
Review comment:
Is there a reason for return false, because BasicOzoneFileSystem does
not return false when key list is empty.
[https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java#L287](codelink)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
