smengcl commented on a change in pull request #1286:
URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r468173915
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java
##########
@@ -190,14 +190,19 @@ public InputStream readFile(String key) throws
IOException {
}
}
+ @Deprecated
protected void incrementCounter(Statistic objectsRead) {
//noop: Use OzoneClientAdapterImpl which supports statistics.
Review comment:
My intention is to encourage new code to explicitly specify `count`
since incrementing by 1 is now "old" with the introduction of batch delete /
batch rename.
And all the existing calls have been migrated to the new one
`incrementCounter(Statistic objectsRead, long count)`.
Actually I can just remove the old method since it is `protected`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
