smengcl commented on a change in pull request #1286:
URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r468176686
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
##########
@@ -220,17 +220,22 @@ protected InputStream createFSInputStream(InputStream
inputStream) {
return new OzoneFSInputStream(inputStream, statistics);
}
+ @Deprecated
protected void incrementCounter(Statistic statistic) {
//don't do anyting in this default implementation.
Review comment:
~~This method body is intentionally left empty in HDDS-1333 for
compatibility fix I believe. Is this no longer the case?~~ should be fine since
the change is only calling another empty method. but I don't see the point of
doing this as we are overriding this in `OzoneFileSystem`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
