GlenGeng commented on a change in pull request #1274: URL: https://github.com/apache/hadoop-ozone/pull/1274#discussion_r496361400
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java ########## @@ -101,12 +103,23 @@ public SCMContainerManager( this.numContainerPerVolume = conf .getInt(ScmConfigKeys.OZONE_SCM_PIPELINE_OWNER_CONTAINER_COUNT, ScmConfigKeys.OZONE_SCM_PIPELINE_OWNER_CONTAINER_COUNT_DEFAULT); + this.numPipelinesPerRaftLogDisk = conf + .getInt(ScmConfigKeys.OZONE_SCM_PIPELINE_PER_RAFT_LOG_DISK, + ScmConfigKeys.OZONE_SCM_PIPELINE_PER_RAFT_LOG_DISK_DEFAULT); loadExistingContainers(); scmContainerManagerMetrics = SCMContainerManagerMetrics.create(); } + private int getOpenContainerCountPerPipeline(Pipeline pipeline) { + int totalContainerCountPerDn = numContainerPerVolume * + pipelineManager.getNumHealthyVolumes(pipeline); + int maxPipelineCountPerDn = pipelineManager.maxPipelineLimit(pipeline); + return (int) Math.ceil( + ((double) totalContainerCountPerDn / maxPipelineCountPerDn)); + } + Review comment: might need change pipeline placement policy to make sure that only allocating pipelines on homogeneous machiens. It one pipeline connects a strong DN and weak DN, its open container number will be `volumeNumOfStrongDN * 3 / pipelineNumOfWeakDN.`,pipeline on the same DN may not be able to evenly distribute open containers of that DN. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org