GlenGeng commented on a change in pull request #1274:
URL: https://github.com/apache/hadoop-ozone/pull/1274#discussion_r497350686
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
##########
@@ -107,6 +107,14 @@ public SCMContainerManager(
scmContainerManagerMetrics = SCMContainerManagerMetrics.create();
}
+ private int getOpenContainerCountPerPipeline(Pipeline pipeline) {
+ int totalContainerCountPerDn = numContainerPerVolume *
Review comment:
name suggestion: totalContainerCountPerDn -> minContainerCountPerDn
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -130,6 +133,11 @@ public SCMNodeManager(OzoneConfiguration conf,
this.useHostname = conf.getBoolean(
DFSConfigKeysLegacy.DFS_DATANODE_USE_DN_HOSTNAME,
DFSConfigKeysLegacy.DFS_DATANODE_USE_DN_HOSTNAME_DEFAULT);
+ this.numPipelinesPerRaftLogDisk =
Review comment:
member var name suggestion: numPipelinesPerMetadataVolume
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -511,7 +521,7 @@ private SCMNodeStat getNodeStatInternal(DatanodeDetails
datanodeDetails) {
}
/**
- * Returns the max of no healthy volumes reported out of the set
+ * Returns the min of no healthy volumes reported out of the set
Review comment:
method name suggestion: minHealthyVolumeNum
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -308,6 +308,10 @@
OZONE_SCM_KEY_VALUE_CONTAINER_DELETION_CHOOSING_POLICY =
"ozone.scm.keyvalue.container.deletion-choosing.policy";
+ public static final String OZONE_SCM_PIPELINE_PER_METADATA_DISK =
Review comment:
name suggestion: OZONE_SCM_PIPELINE_PER_METADATA_VOLUME.
We'd better use concept volume instead of concept disk in SCM, the former
one is a logical concept, the latter is physical one, and volume is already
widely used in context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
