prashantpogde commented on a change in pull request #1457: URL: https://github.com/apache/hadoop-ozone/pull/1457#discussion_r498600060
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java ########## @@ -240,8 +247,19 @@ public VersionResponse getVersion(SCMVersionRequestProto versionRequest) { @Override public RegisteredCommand register( DatanodeDetails datanodeDetails, NodeReportProto nodeReport, - PipelineReportsProto pipelineReportsProto) { - + PipelineReportsProto pipelineReportsProto, + LayoutVersionProto layoutInfo) { + + if (layoutInfo != null) { + if (layoutInfo.getSoftwareLayoutVersion() > + scmLayoutVersionManager.getSoftwareLayoutVersion()) { Review comment: SCM can handle multiple DNs and it may make log verbose. This will be thrown back to the DN and it will be logged there for debugging as to why datanode is not able to register with SCM. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org