prashantpogde commented on a change in pull request #1457:
URL: https://github.com/apache/hadoop-ozone/pull/1457#discussion_r498600324
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -240,8 +247,19 @@ public VersionResponse getVersion(SCMVersionRequestProto
versionRequest) {
@Override
public RegisteredCommand register(
DatanodeDetails datanodeDetails, NodeReportProto nodeReport,
- PipelineReportsProto pipelineReportsProto) {
-
+ PipelineReportsProto pipelineReportsProto,
+ LayoutVersionProto layoutInfo) {
+
+ if (layoutInfo != null) {
Review comment:
thanks @avijayanhwx for the review. I thought about it while I wrote
this. I wanted all registration related processing for all the passed
parameters to be consolidated in one place and it seems like
NodeManager.register is the right place even though we have to add another
parameter in bunch of places. Majority of these places are unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
