https://bugzilla.redhat.com/show_bug.cgi?id=843997
--- Comment #6 from Ryan Curtin <[email protected]> --- > 1) Why is not the LICENSE.txt in the main package? Oops, I did not realize I should be distributing that. I modified the spec to install LICENSE.txt. > 2) Another issue that is not an error but I am curious, why is not the > documentation (doc directory content) packaged? The documentation is Doxygen-generated HTML which a user could more easily access at mlpack.org (it is prettier there, too). I don't think it's necessary to include that amount of stuff with the distribution, especially when a user could generate it themselves using Doxygen painlessly. > 3) In patch 4 there is a reference to the eminent release of 3.6. I suspect that you referring to armadillo 3.4. :-) At the time I wrote the comment, sparse matrix support was expected in 3.6, but fortunately that was not how it turned out. > 4) Do you intend to release this package for EPEL5? If not the package can be > simplified in some parts. It may be useful to release for EPEL5 because some academic settings may still be using RHEL5 (in fact where I am, RHEL5 is still the main choice and there are even RHEL4 boxes floating around in some particularly unfortunate cases). I have again updated the spec file and srpm, built on koji, and made it all available: spec: http://www.mlpack.org/files/mlpack.spec srpm: http://www.mlpack.org/files/mlpack-1.0.1-4.fc17.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4490465 Let me know if there are more issues I should address. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
