Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=881431

Eduardo Echeverria <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #6 from Eduardo Echeverria <[email protected]> ---
(In reply to comment #5)
> Hi François.
> 
> Just some comments from a inexpert packager. :)
> 
> - %clean section should be omitted from Fedora 13 and above
> (http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) even if I see
> it included frequently. 
> 
> - %defattr(-,root,root,-) should be also omitted
> http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

Antonio, From what I see, François want to build in EPEL5, so these guidelines
do not apply here.

François please confirms if you want to build your package in EPEL5.

Issues: 
- you using both %{buildroot} and $RPM_BUILD_ROOT, please use consistently  
RPM_BUILD_ROOT or %{buildroot}
http://fedoraproject.org/wiki/Packaging/Guidelines#macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to