Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881431
--- Comment #7 from Antonio Trande <[email protected]> --- (In reply to comment #6) > (In reply to comment #5) > > Hi François. > > > > Just some comments from a inexpert packager. :) > > > > - %clean section should be omitted from Fedora 13 and above > > (http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) even if I see > > it included frequently. > > > > - %defattr(-,root,root,-) should be also omitted > > http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > > Antonio, From what I see, François want to build in EPEL5, so these > guidelines do not apply here. > > François please confirms if you want to build your package in EPEL5. > > Issues: > - you using both %{buildroot} and $RPM_BUILD_ROOT, please use consistently > RPM_BUILD_ROOT or %{buildroot} > http://fedoraproject.org/wiki/Packaging/Guidelines#macros Hi Eduardo. His source rpm is for Fedora 16. If it was for EPEL5, then it should be packaged as el5 ... This leads me to think to Fedora packaging rules. :) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
