Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=863145

Michael Schwendt <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |NotReady

--- Comment #4 from Michael Schwendt <[email protected]> ---
> %build
> make %{?_smp_mflags}

build.log output says:

+ cd listadmin-2.40
+ make -j2
Nothing needs to be done
+ exit 0

Not a big issue, but it's possible to leave the %build section empty. You could
even delete the %build section completely.

If you want to keep running "make" because there is a Makefile, the invocation
should change the default PREFIX=/usr/local to be in sync with the %install
section. "make PREFIX=/usr", else it could happen that the wrong PREFIX would
enter built files, e.g. via substitutions (or compilation for other packages in
general).


> %doc %{_mandir}/man1/listadmin.1.gz

As in comment 2, files below %{_mandir} are marked as %doc automatically. It's
not necessary to use %doc here explicitly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Q7sL0h8X72&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to