Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919044
Antonio Trande <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Antonio Trande <[email protected]> --- Hi Eugene. Some initial comments. - Source link is wrog, it's a https. - gcc-c++ can be omitted http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 - Description line is too long, it must not exceed 80 characters - %{__rm} -rf %{buildroot} and %clean section are not necessary http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean - %defattr(-,root,root,-) is no necessary http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions - License should be a GPLv2. - Package includes a .desktop file, add a desktop-file-validation to .spec file http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage - Changelog should regard the RPM history in Fedora starting from initial package created for Fedora review. The number includes also the release so it is 0.9.1-1. - Vendor tag should not be used http://fedoraproject.org/wiki/Packaging:Guidelines#Tags -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vp9rDjgZSq&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
