Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=919044

--- Comment #4 from Eugene A. Pivnev <[email protected]> ---
(In reply to comment #1)
> - Source link is wrog, it's a https.
Real current link: http://screengrab.doomer.org/download/screengrab-0_9_1_/
(http://screengrab.doomer.org/download/) - but it is not spec-compatible. I
don't know what to do.

> - gcc-c++ can be omitted
Fixed

> - Description line is too long, it must not exceed 80 characters
Fixed

> - %{__rm} -rf %{buildroot} and %clean section are not necessary
Fixed

> - %defattr(-,root,root,-) is no necessary
Fixed

> - License should be a GPLv2.
I used src/main.cpp head

> - Package includes a .desktop file, add a desktop-file-validation to .spec 
> file
Fixed

> - Changelog should regard the RPM history in Fedora starting from initial
> package created for Fedora review. The number includes also the release so
> it is 0.9.1-1.
Fixed

> - Vendor tag should not be used 
Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=2MSE0SwNVd&a=cc_unsubscribe
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to